Improve RCT-Folly so that other dependencies don't have to specify the folly flags (#49812) #49969
+26
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71032640 |
|
This pull request was exported from Phabricator. Differential Revision: D71032640 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 12, 2025
…e folly flags (facebook#49969) Summary: Pull Request resolved: facebook#49969 Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Pull Request resolved: facebook#49812 Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Reviewed By: javache Differential Revision: D71032640 Pulled By: cipolleschi
cipolleschi
force-pushed
the
export-D71032640
branch
from
fb7658b to
21f2975
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71032640 |
cipolleschi
force-pushed
the
export-D71032640
branch
from
21f2975 to
02d4904
Compare
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 12, 2025
…e folly flags (facebook#49969) Summary: Pull Request resolved: facebook#49969 Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Pull Request resolved: facebook#49812 Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Reviewed By: javache Differential Revision: D71032640 Pulled By: cipolleschi
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 12, 2025
…e folly flags (facebook#49969) Summary: Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Reviewed By: javache Differential Revision: D71032640 Pulled By: cipolleschi
cipolleschi
force-pushed
the
export-D71032640
branch
from
02d4904 to
12d29ad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71032640 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 12, 2025
…e folly flags (facebook#49969) Summary: Pull Request resolved: facebook#49969 Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Pull Request resolved: facebook#49812 Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Differential Revision: D71032640 Reviewed By: javache Pulled By: javache
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 12, 2025
…e folly flags (facebook#49969) Summary: Pull Request resolved: facebook#49969 Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Pull Request resolved: facebook#49812 Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Differential Revision: D71032640 Reviewed By: javache Pulled By: javache
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 12, 2025
…e folly flags (facebook#49969) Summary: Pull Request resolved: facebook#49969 Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Pull Request resolved: facebook#49812 Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Differential Revision: D71032640 Reviewed By: javache Pulled By: javache
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 12, 2025
…e folly flags (facebook#49969) Summary: Pull Request resolved: facebook#49969 Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Pull Request resolved: facebook#49812 Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Differential Revision: D71032640 Reviewed By: javache Pulled By: javache
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 12, 2025
…e folly flags (facebook#49969) Summary: Pull Request resolved: facebook#49969 Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Pull Request resolved: facebook#49812 Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Differential Revision: D71032640 Reviewed By: javache Pulled By: javache
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 12, 2025
…e folly flags (facebook#49969) Summary: Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Reviewed By: javache Differential Revision: D71032640 Pulled By: cipolleschi
cipolleschi
force-pushed
the
export-D71032640
branch
from
12d29ad to
1bffe29
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71032640 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 12, 2025
…e folly flags (facebook#49969) Summary: Pull Request resolved: facebook#49969 Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Pull Request resolved: facebook#49812 Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Differential Revision: D71032640 Reviewed By: javache Pulled By: javache
cipolleschi
force-pushed
the
export-D71032640
branch
from
1bffe29 to
cfe90fb
Compare
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2025
…e folly flags (facebook#49969) Summary: Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Reviewed By: javache Differential Revision: D71032640 Pulled By: cipolleschi
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2025
…e folly flags (facebook#49969) Summary: Pull Request resolved: facebook#49969 Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Pull Request resolved: facebook#49812 Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Differential Revision: D71032640 Reviewed By: javache Pulled By: javache
…e folly flags (facebook#49969) Summary: Pull Request resolved: facebook#49969 Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Reviewed By: javache Differential Revision: D71032640 Pulled By: cipolleschi
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2025
…e folly flags (facebook#49969) Summary: Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Reviewed By: javache Differential Revision: D71032640 Pulled By: cipolleschi
cipolleschi
force-pushed
the
export-D71032640
branch
from
cfe90fb to
ba944c2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71032640 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2025
…e folly flags (facebook#49969) Summary: Pull Request resolved: facebook#49969 Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Pull Request resolved: facebook#49812 Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Differential Revision: D71032640 Reviewed By: javache Pulled By: javache
|
This pull request was exported from Phabricator. Differential Revision: D71032640 |
cipolleschi
force-pushed
the
export-D71032640
branch
from
ba944c2 to
30fb61b
Compare
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2025
…e folly flags (facebook#49969) Summary: Pull Request resolved: facebook#49969 Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Pull Request resolved: facebook#49812 Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Differential Revision: D71032640 Reviewed By: javache Pulled By: javache
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2025
…e folly flags (facebook#49969) Summary: Pull Request resolved: facebook#49969 Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Pull Request resolved: facebook#49812 Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Differential Revision: D71032640 Reviewed By: javache Pulled By: javache
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2025
…e folly flags (facebook#49969) Summary: Pull Request resolved: facebook#49969 Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Pull Request resolved: facebook#49812 Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Differential Revision: D71032640 Reviewed By: javache Pulled By: javache
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2025
…e folly flags (facebook#49969) Summary: Pull Request resolved: facebook#49969 Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Pull Request resolved: facebook#49812 Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Differential Revision: D71032640 Reviewed By: javache Pulled By: javache
|
@cipolleschi merged this pull request in e876e49. |
|
This pull request was successfully merged by @chrfalch in e876e49 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies.
Changelog:
[INTERNAL] - Configure folly in a prepare step
Test Plan:
✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs
✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities
Differential Revision: D71032640
Pulled By: cipolleschi